cores: arduino: zephyrSerial: Add cast to suppress warning#144
Merged
DhruvaG2000 merged 1 commit intozephyrproject-rtos:nextfrom Feb 3, 2026
Merged
cores: arduino: zephyrSerial: Add cast to suppress warning#144DhruvaG2000 merged 1 commit intozephyrproject-rtos:nextfrom
DhruvaG2000 merged 1 commit intozephyrproject-rtos:nextfrom
Conversation
soburi
changed the title
soburi
requested review from
DhruvaG2000,
beriberikix and
szczys
as code owners
There was a problem hiding this comment.
Pull request overview
This PR includes multiple unrelated changes bundled together. The title suggests it only adds a cast to suppress a warning in zephyrSerial.cpp, but it also significantly modifies CMakeLists.txt files across the project to support board revision-specific overlay files and update variant directory selection logic.
Changes:
- Added explicit cast from
unsigned longtouint32_tfor baudrate in zephyrSerial.cpp - Modified root CMakeLists.txt to normalize board target names and update variant directory selection
- Added conditional logic to all sample CMakeLists.txt files to support board revision-specific overlay files
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| cores/arduino/zephyrSerial.cpp | Added cast to convert baud parameter from unsigned long to uint32_t |
| CMakeLists.txt | Modified variant directory selection logic and added string replacement for NORMALIZED_BOARD_TARGET |
| samples/threads_arduino/CMakeLists.txt | Added conditional logic to select board revision-specific overlay files |
| samples/spi_controller/CMakeLists.txt | Added conditional logic to select board revision-specific overlay files |
| samples/serial_event/CMakeLists.txt | Added conditional logic to select board revision-specific overlay files |
| samples/i2cdemo/CMakeLists.txt | Added conditional logic to select board revision-specific overlay files |
| samples/hello_arduino/CMakeLists.txt | Added conditional logic to select board revision-specific overlay files |
| samples/fade/CMakeLists.txt | Added conditional logic to select board revision-specific overlay files |
| samples/button_press_led/CMakeLists.txt | Added conditional logic to select board revision-specific overlay files |
| samples/blinky_arduino/CMakeLists.txt | Added conditional logic to select board revision-specific overlay files |
| samples/attach_interrupt/CMakeLists.txt | Added conditional logic to select board revision-specific overlay files |
| samples/analog_input/CMakeLists.txt | Added conditional logic to select board revision-specific overlay files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
soburi
force-pushed
the
zephyr_serial_warning
branch
from
c3aa1cc to
2d40131
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
soburi
force-pushed
the
zephyr_serial_warning
branch
from
2d40131 to
42c29a9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There is no practical concern that the baud rate will exceed 32-bit size, so there is no problem with casting. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
zephyr_serial_warning
branch
from
42c29a9 to
924c35b
Compare
DhruvaG2000
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no practical concern that the baud rate will exceed 32-bit size,
so there is no problem with casting.