Fix micros() for nano without breaking giga#174
Open
soburi wants to merge 1 commit intozephyrproject-rtos:nextfrom
Open
Fix micros() for nano without breaking giga#174soburi wants to merge 1 commit intozephyrproject-rtos:nextfrom
soburi wants to merge 1 commit intozephyrproject-rtos:nextfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates micros() to use Zephyr’s 64-bit cycle counter when the platform supports it, while preserving compatibility with targets that only provide a 32-bit cycle counter (e.g., Nano).
Changes:
- Adds a
CONFIG_TIMER_HAS_64BIT_CYCLE_COUNTERcompile-time check inmicros(). - Uses
k_cycle_get_64()on 64-bit cycle-counter platforms and falls back tok_cycle_get_32()otherwise.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The rollover fix for the giga used the 64 bit timer instead of 32
bits. The nano does not have a 64 bit timer, so you need to use
the 32 bit instead.
So I know check to see if the processor supports 64 bits if so use it
else fall back to 32 bit.
Note: This branch doesn't include support for Arduino Giga,
but we'll include it as it's a reasonable solution for
preventing timer overflows.
Co-Authored-by: Kurt Eckhardt <kurte@rockisland.com>
Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rollover fix for the giga used the 64 bit timer instead of 32 bits. The nano does not have a 64 bit timer, so you need to use the 32 bit instead.
So I know check to see if the processor supports 64 bits if so use it else fall back to 32 bit.
Note: This branch doesn't include support for Arduino Giga,
but we'll include it as it's a reasonable solution for
preventing timer overflows.