cores: arduino: zephyrCommon: rework tone slot handling and timer lifecycle#176
Open
soburi wants to merge 1 commit intozephyrproject-rtos:nextfrom
Open
cores: arduino: zephyrCommon: rework tone slot handling and timer lifecycle#176soburi wants to merge 1 commit intozephyrproject-rtos:nextfrom
soburi wants to merge 1 commit intozephyrproject-rtos:nextfrom
Conversation
soburi
changed the title
soburi
requested review from
DhruvaG2000,
beriberikix and
szczys
as code owners
There was a problem hiding this comment.
Pull request overview
This PR reworks the Arduino tone() / noTone() implementation for the Zephyr-based core to better match Arduino behavior and make concurrent tone usage configurable and safer.
Changes:
- Introduces slot-based tone handling (via
pin_timerentries) instead of per-pin timer arrays, plus a configuration mutex to serialize tone configuration. - Reworks finite-tone completion to be handled by counting remaining toggles directly in
tone_expiry_cb()(removing the need for a companion timeout timer). - Updates
CONFIG_ARDUINO_MAX_TONEShelp text and removes theUSE_ARDUINO_API_RUST_IMPLEMENTATIONKconfig option.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| cores/arduino/zephyrCommon.cpp | Implements slot-based tone timers, adds mutex-guarded timer lifecycle, and updates the expiry callback logic. |
| Kconfig | Adjusts ARDUINO_MAX_TONES help text and removes a Rust-core selection config symbol. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ecycle Rework tone/noTone internals to better match Arduino behavior while making concurrent tone usage configurable and safer. - Add CONFIG_ARDUINO_MAX_TONES (default: -1). - Negative values fall back to the digital pin count from devicetree. - Replace per-pin tone timer arrays with slot-based pin_timer entries. - Remove the timeout companion timer and finish finite tones by counting remaining toggles in tone_expiry_cb(). Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework tone/noTone internals to better match Arduino behavior while making
concurrent tone usage configurable and safer.
remaining toggles in tone_expiry_cb().