core: Introduce digitalPinTo(PortDevice|PinIndex)#187
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Arduino-style helpers for mapping a digital pin to its underlying Zephyr GPIO port device and pin index, and introduces an F_CPU definition for ARM builds to improve compatibility with Arduino libraries that expect it.
Changes:
- Add
digitalPinToPortDevice()anddigitalPinToPinIndex()APIs to expose Zephyr GPIO mapping for a given Arduino pin. - Define
F_CPUfor__arm__targets.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cores/arduino/zephyrCommon.cpp | Implements the new digitalPinToPortDevice() / digitalPinToPinIndex() mapping helpers. |
| cores/arduino/Arduino.h | Declares the new mapping APIs and defines F_CPU for ARM targets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
soburi
force-pushed
the
digitalPinToX
branch
2 times, most recently
from
b8c50b7 to
5b38871
Compare
soburi
force-pushed
the
digitalPinToX
branch
3 times, most recently
from
a1c7a9e to
9faf453
Compare
DhruvaG2000
approved these changes
Jun 1, 2026
DhruvaG2000
left a comment
DhruvaG2000
left a comment
Member
There was a problem hiding this comment.
Other than one minor comment good to go.
| #endif | ||
|
|
||
| #if defined(__arm__) | ||
| #define F_CPU (SystemCoreClock) |
Member
There was a problem hiding this comment.
Please split the F cpu change into its own commit.
Add digitalPinToPortDevice() and digitalPinToPinIndex(). Co-authored-by: Martino Facchin <m.facchin@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Add F_CPU definition for retrive CPU frequency. Co-authored-by: Martino Facchin <m.facchin@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add digitalPinToPortDevice() and digitalPinToPinIndex(). Also define F_CPU for ARM targets.