zephyrSerial: Keeping up with UART API changes#191
Merged
Conversation
Update for uart_irq_update() changes introduced with zephyrproject-rtos/zephyr#105231. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Member
Author
|
@DhruvaG2000 |
There was a problem hiding this comment.
Pull request overview
Updates ZephyrSerial’s IRQ handler to remain compatible with Zephyr’s updated UART interrupt API (per zephyrproject-rtos/zephyr#105231), by no longer relying on uart_irq_update()’s previous boolean return semantics.
Changes:
- Replace the conditional early-return on
uart_irq_update()with an unconditional call whose return value is ignored.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Please do this as well. |
DhruvaG2000
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for uart_irq_update() changes introduced with zephyrproject-rtos/zephyr#105231.