Skip to content

Commit da9ff81

Browse files
zer0yuclaude
andcommitted
fix: update tests for 3-tuple return and fix function shadowing bug
- Fix function name shadowing issue in add_feed_to_tree (category_name parameter vs function) - Update tests to handle new 3-tuple return value (added, target, was_updated) - All tests now passing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent c7fa062 commit da9ff81

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

scripts/add_feed_to_tiny.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,8 @@ def add_feed_to_tree(
262262
# Return the existing category name
263263
if old_parent is body:
264264
return False, "(top-level)", False
265-
name = category_name(old_parent)
265+
# Get category name from the parent element (inline to avoid shadowing)
266+
name = (old_parent.attrib.get("title") or old_parent.attrib.get("text") or "").strip()
266267
return False, name or "(unnamed)", False
267268

268269
# Update the existing feed

tests/test_add_feed_to_tiny.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def test_add_feed_creates_missing_category(self):
6868
</opml>
6969
"""
7070
)
71-
added, target = add_feed_to_tree(
71+
added, target, was_updated = add_feed_to_tree(
7272
tree=tree,
7373
category_name="ThreatIntel",
7474
metadata=FeedMetadata(
@@ -79,6 +79,7 @@ def test_add_feed_creates_missing_category(self):
7979
)
8080
self.assertTrue(added)
8181
self.assertEqual(target, "ThreatIntel")
82+
self.assertFalse(was_updated)
8283
self.assertEqual(
8384
rss_urls_in_category(tree, "ThreatIntel"),
8485
["https://ti.example.com/feed.xml"],
@@ -99,7 +100,7 @@ def test_add_feed_skips_duplicate_xml_url(self):
99100
</opml>
100101
"""
101102
)
102-
added, target = add_feed_to_tree(
103+
added, target, was_updated = add_feed_to_tree(
103104
tree=tree,
104105
category_name="Dev",
105106
metadata=FeedMetadata(
@@ -110,6 +111,7 @@ def test_add_feed_skips_duplicate_xml_url(self):
110111
)
111112
self.assertFalse(added)
112113
self.assertEqual(target, "Dev")
114+
self.assertFalse(was_updated)
113115
self.assertEqual(
114116
rss_urls_in_category(tree, "Dev"),
115117
["https://x.example.com/feed.xml"],

0 commit comments

Comments
 (0)