Seeds & Tests

[Mattsface]

Seeds and Tests

Objective

Provide a reliable testing and development data foundation so features can be validated with repeatable tests and realistic data.

---

Scope

Seed Data

• CLI command to populate the database with test data
• At least three test users
• Sample matches in PENDING, SUBMITTED, APPROVED, and DECLINED states
• Game results for stats and workflow testing
• Edge cases such as users with no matches

Test Infrastructure

• Pytest factories for users, matches, and games
• Database fixtures that reset state per test
• Authentication helpers for obtaining tokens
• FastAPI test client configuration

Coverage

• Authentication flows
• Permission and access control
• Match lifecycle (create → submit → approve/decline)
• Stats calculations
• Failure and edge cases

---

Success Criteria

Test Quality

• pytest passes locally and in CI
• Test suite completes in under 30 seconds
• No flaky or nondeterministic tests
• Core workflows are covered

Seed Data

• Supports manual QA and development
• Can be reset and re-run easily
• Includes all match states and game types

Developer Experience

• New developers can run tests immediately
• Test failures provide clear, actionable output
• Regressions are caught before release

---

Current State

• Basic pytest configuration exists
• One health check test is present
• No factories, fixtures, or seed data
• No authentication helpers
• Minimal overall test coverage

---

Dependencies

• Issue Database Models That Don't Live in Fantasy Land 🎱 #3 — Database models
• Issue #2 — JWT authentication
• Required for CI and all future feature work

[Mattsface]

Quick update for issue #6

• Current status: core models wired up; tests exercising relationships and constraints are in place and passing locally.

• What I did

  • Re-exported Base, User, Match, Game in corner_pocket_backend/models/__init__.py so relationship("Game") resolves during mapper config.
  • Switched MatchStatus to a string enum so tests can compare directly to strings.
  • Enabled SQLite FK enforcement in the test db_session via a connect hook (PRAGMA foreign_keys=ON) and verified it’s active.
  • Tightened the FK test to assert IntegrityError on invalid user IDs.
  • Minor test cleanup: import models via the package to ensure all models are registered before metadata.create_all.

• Next up

  • Update models/base.py to from sqlalchemy.orm import declarative_base (SQLAlchemy 2.x).
  • Mark creator_id/opponent_id as nullable=False in Match.
  • Add a couple more tests around Match.games and Game.match for back_populates.
  • Consider Alembic migration scaffolding for when we move off in-memory SQLite.

• Notes

  • The original “Game not found” was import order/registration; fixed by package re-export.
  • FK behavior in SQLite depends on per-connection PRAGMA; the connect hook ensures consistency.