You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 2, 2026. It is now read-only.
Thanks! I think adding a new variant to RichPattern is fine also, and might be worth it for the ability to disambiguate at a type level (we don't want end users pattern-matching on strings, if we can help it). If you could, also added #[non_exhaustive] to the enum would also be great. It's a breaking change, but there are already several of those lined up anyway!
Thanks! I think adding a new variant to RichPattern is fine also...
How would you like that to work feature wise? If we added RichPattern::Number it wouldn't really make sense if a user wasn't using the lexical-numbers feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to use the
number::Numberparsers with theRicherror type asRichPatterndoes not implementFrom<ExpectedNumber>.This PR adds the missing impl in the
numbermodule so it is appropriatley feature gated.Not previously possible: