Skip to content

Commit 3993fe6

Browse files
committed
ci: add RelWithDebInfo build to trigger a compile error
1 parent a080eb0 commit 3993fe6

2 files changed

Lines changed: 17 additions & 7 deletions

File tree

.github/workflows/test.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,15 @@ env:
4040
jobs:
4141
ubuntu:
4242
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
43-
name: AMD64 Ubuntu 26.04
43+
name: AMD64 Ubuntu 26.04 (${{ matrix.cmake_build_type }})
4444
runs-on: ubuntu-26.04
4545
timeout-minutes: 30
4646
strategy:
4747
fail-fast: false
48+
matrix:
49+
cmake_build_type:
50+
- Debug
51+
- RelWithDebInfo
4852
env:
4953
SCCACHE_DIR: ${{ github.workspace }}/.sccache
5054
SCCACHE_CACHE_SIZE: "2G"
@@ -70,7 +74,7 @@ jobs:
7074
env:
7175
CC: gcc-14
7276
CXX: g++-14
73-
run: ci/scripts/build_iceberg.sh $(pwd) ON ON
77+
run: ci/scripts/build_iceberg.sh $(pwd) ON ON OFF OFF ON ${{ matrix.cmake_build_type }}
7478
- name: Show sccache stats
7579
shell: bash
7680
run: sccache --show-stats

ci/scripts/build_iceberg.sh

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
# specific language governing permissions and limitations
1818
# under the License.
1919
#
20-
# Usage: build_iceberg.sh <source_dir> [rest_integration_tests=OFF] [sccache=OFF] [s3=OFF] [sigv4=OFF] [bundle_awssdk=ON]
20+
# Usage: build_iceberg.sh <source_dir> [rest_integration_tests=OFF] [sccache=OFF] [s3=OFF] [sigv4=OFF] [bundle_awssdk=ON] [build_type=Debug]
2121

2222
set -eux
2323

@@ -37,6 +37,12 @@ is_windows() {
3737
[[ "${OSTYPE}" == "msys" || "${OSTYPE}" == "win32" || "${OSTYPE}" == "cygwin" ]]
3838
}
3939

40+
if is_windows; then
41+
build_type=${7:-Release}
42+
else
43+
build_type=${7:-Debug}
44+
fi
45+
4046
CMAKE_ARGS=(
4147
"-G Ninja"
4248
"-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX:-${ICEBERG_HOME}}"
@@ -65,13 +71,13 @@ fi
6571

6672
if is_windows; then
6773
CMAKE_ARGS+=("-DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake")
68-
CMAKE_ARGS+=("-DCMAKE_BUILD_TYPE=Release")
74+
CMAKE_ARGS+=("-DCMAKE_BUILD_TYPE=${build_type}")
6975
else
7076
# Pass an externally provided toolchain (e.g. vcpkg for the SigV4 job)
7177
if [[ -n "${CMAKE_TOOLCHAIN_FILE:-}" ]]; then
7278
CMAKE_ARGS+=("-DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}")
7379
fi
74-
CMAKE_ARGS+=("-DCMAKE_BUILD_TYPE=Debug")
80+
CMAKE_ARGS+=("-DCMAKE_BUILD_TYPE=${build_type}")
7581
fi
7682

7783
if [[ "${build_enable_sccache}" == "ON" ]]; then
@@ -86,9 +92,9 @@ fi
8692

8793
cmake "${CMAKE_ARGS[@]}" ${source_dir}
8894
if is_windows; then
89-
cmake --build . --config Release --target install
95+
cmake --build . --config "${build_type}" --target install
9096
if [[ "${run_tests}" == "ON" ]]; then
91-
ctest --output-on-failure -C Release
97+
ctest --output-on-failure -C "${build_type}"
9298
fi
9399
else
94100
cmake --build . --target install

0 commit comments

Comments
 (0)