add literal IsNaN check

zhjwpku · zhjwpku · commit 6acc07afc89e · 2025-11-26T23:15:42.000+08:00
diff --git a/src/iceberg/expression/predicate.cc b/src/iceberg/expression/predicate.cc
@@ -71,6 +71,10 @@ Result<std::unique_ptr<UnboundPredicateImpl<B>>> UnboundPredicateImpl<B>::Make(
     return InvalidExpression("Cannot create {} predicate inclusive a value",
                              ::iceberg::ToString(op));
   }
+  if (value.IsNaN()) [[unlikely]] {
+    return InvalidExpression(
+        "Invalid expression literal: NaN, use isNaN or notNaN instead");
+  }
   return std::unique_ptr<UnboundPredicateImpl<B>>(
       new UnboundPredicateImpl<B>(op, std::move(term), std::move(value)));
 }

Original file line number	Diff line number	Diff line change
`@@ -71,6 +71,10 @@ Result<std::unique_ptr<UnboundPredicateImpl<B>>> UnboundPredicateImpl<B>::Make(`
`71`	`71`	`return InvalidExpression("Cannot create {} predicate inclusive a value",`
`72`	`72`	`::iceberg::ToString(op));`
`73`	`73`	`}`
	`74`	`+ if (value.IsNaN()) [[unlikely]] {`
	`75`	`+ return InvalidExpression(`
	`76`	`+ "Invalid expression literal: NaN, use isNaN or notNaN instead");`
	`77`	`+ }`
`74`	`78`	`return std::unique_ptr<UnboundPredicateImpl<B>>(`
`75`	`79`	`new UnboundPredicateImpl<B>(op, std::move(term), std::move(value)));`
`76`	`80`	`}`