ci(windows): find vcvarsall via vswhere instead of hardcoded VS path

Author: zhjwpku

.github/workflows/test.yml

@@ -103,14 +103,14 @@ jobs:
           SCCACHE_GHA_ENABLED: "true"
         run: |
           $ErrorActionPreference = "Stop"
-          cmd /c "call `"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat`" x64 && bash -lc `"ci/scripts/build_iceberg.sh `$(pwd) OFF ON`""
+          & "${env:GITHUB_WORKSPACE}/ci/scripts/run_msvc_bash.ps1" -BashCommand 'ci/scripts/build_iceberg.sh $(pwd) OFF ON'
           if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
           sccache --show-stats
       - name: Build Example
         shell: pwsh
         run: |
           $ErrorActionPreference = "Stop"
-          cmd /c "call `"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat`" x64 && bash -lc `"ci/scripts/build_example.sh `$(pwd)/example`""
+          & "${env:GITHUB_WORKSPACE}/ci/scripts/run_msvc_bash.ps1" -BashCommand 'ci/scripts/build_example.sh $(pwd)/example'
   meson:
     name: Meson - ${{ matrix.title }}
     runs-on: ${{ matrix.runs-on }}

ci/scripts/run_msvc_bash.ps1

@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Run a Bash command line (passed to bash -lc) after initializing MSVC via
+# vcvarsall.bat. Locates Visual Studio using vswhere so CI works across
+# Enterprise, Community, Build Tools, and future image layouts.
+
+param(
+    [Parameter(Mandatory = $true)]
+    [string]$BashCommand
+)
+
+$ErrorActionPreference = "Stop"
+
+$vswhere = Join-Path ${env:ProgramFiles(x86)} "Microsoft Visual Studio\Installer\vswhere.exe"
+if (-not (Test-Path -LiteralPath $vswhere)) {
+    Write-Error "vswhere.exe not found: $vswhere"
+    exit 1
+}
+
+$installationPath = & $vswhere `
+    -latest -products * `
+    -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 `
+    -property installationPath
+
+if ([string]::IsNullOrWhiteSpace($installationPath)) {
+    $installationPath = & $vswhere -latest -products * -property installationPath
+}
+
+if ([string]::IsNullOrWhiteSpace($installationPath)) {
+    Write-Error "No Visual Studio installation with C++ tools found via vswhere."
+    exit 1
+}
+
+$vcvarsall = Join-Path $installationPath "VC\Auxiliary\Build\vcvarsall.bat"
+if (-not (Test-Path -LiteralPath $vcvarsall)) {
+    Write-Error "vcvarsall.bat not found: $vcvarsall"
+    exit 1
+}
+
+cmd.exe /c "call `"$vcvarsall`" x64 && bash -lc `"$BashCommand`""
+exit $LASTEXITCODE