#724 Enable URL liveness check for release builds by Abdulbois · Pull Request #729 · zigbee-alliance/distributed-compliance-ledger

Abdulbois · 2026-05-02T08:51:40Z

Introduces a dev build tag to setup dev env dependent flags
Add URL liveness checks in CLI tx command for prod release

Closes #724

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

…b CI Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

ashcherbakov · 2026-05-08T14:02:20Z

@@ -49,27 +53,78 @@ func requiredIfBit0Set(fl validator.FieldLevel) bool {
 }

 func isValidHttpOrHttpsUrl(fl validator.FieldLevel) bool { //nolint:stylecheck


Reachability checks cannot be implemented here, because it's part of ValidateBasic function which is part of the static validation, see https://csa-matter.slack.com/archives/C025PQ6RMRA/p1777291064854469.
Please implement reachability checks in separate dedicated functions which should be called only within CLI directly, as described in the original ticket.

Update, but it is called(should be called) before the broadcasting txn to the DCLD nodes(before tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg) call)

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

ashcherbakov · 2026-05-11T16:33:22Z

+var allowed4XXStatusCodes = []int{
+	http.StatusUnauthorized,
+	http.StatusForbidden,
+	http.StatusUnavailableForLegalReasons,


Do we want to include also 405 Method Not Allowed — server rejects HEAD specifically?
Another option can be to treat any status beside 404 (and 5xx?) as reachable.

Added 405. For the second option, as I know, when the server is down, it should return a 5xx code even requested page does not exist

Yes, if the server is down - you only get server codes, not resource.

ashcherbakov · 2026-05-11T16:42:05Z

 				specificationVersion,
 			)

+			if releaseNotesURL != "" && !cli.IsLiveURL(releaseNotesURL) {


What about otaURL?

ashcherbakov · 2026-05-11T16:42:13Z

 				schemaVersion,
 			)

+			if releaseNotesURL != "" && !cli.IsLiveURL(releaseNotesURL) {


What about otaURL?

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

AzizMukhtorjonov · 2026-05-13T11:05:27Z

        env:
          GH_TOKEN: ${{ secrets.GH_TOKEN }}
-          GOCOVER_MODE: set  # Ensure integration tests use the same mode as unit tests
+          GOCOVER_MODE: set  # Ensure integration tests use the same mode as unit tests\


Suggested change

GOCOVER_MODE: set # Ensure integration tests use the same mode as unit tests\

GOCOVER_MODE: set # Ensure integration tests use the same mode as unit tests

AzizMukhtorjonov · 2026-05-13T11:12:29Z

+var httpClient = &http.Client{Timeout: livenessCheckTimeout}
+
+func IsLiveURL(u string) bool {
+	if config.DisableURLLivenessCheck {


Let's rename it to URLLivenessCheckEnabled.

Mark it as a boolean flag because Disable looks more like function name than boolean flag.

Change negative to positive. It is easier to read URLLivenessCheckEnabled thus !URLLivenessCheckEnabled than URLLivenessCheckDisabled.

Renamed to URLLivenessCheckEnabled

AzizMukhtorjonov · 2026-05-13T11:14:13Z

+var allowed4XXStatusCodes = []int{
+	http.StatusUnauthorized,
+	http.StatusForbidden,
+	http.StatusUnavailableForLegalReasons,


Yes, if the server is down - you only get server codes, not resource.

AzizMukhtorjonov · 2026-05-13T11:35:19Z

+// Empty strings are skipped.
+//
+// Returns an empty string if all non-empty URLs are reachable.
+func FirstUnreachableURL(urls ...string) string {


As far as I understand - reason of having this function is to throw error if ANY of given urls are not reachable.

It would be more UX friendly if we can give info on ALL unreachable urls in one check.

Worst case for both scenarios - timeout.
Best case for FirstUnreachableURL - when any of calls gives error.
Best case for CheckURLsForReachability - when all calls are completed.

@ashcherbakov what do you think?

I think it makes sense to provide a list of all unreachable URLs at the same time for better UX.

AzizMukhtorjonov · 2026-05-13T11:41:10Z

 test:
-	go test -v $(PACKAGES)
+	go test -tags=dev -v $(PACKAGES)
+	go test -v utils/cli/url_liveness.go  utils/cli/url_liveness_test.go


Can we move these files into variable just like PACKAGES?

No, because url_liveness_test.go should be executed without dev tag

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Enable URL liveness check for release builds

7ada368

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Abdulbois changed the title ~~Enable URL liveness check for release builds~~ #724 Enable URL liveness check for release builds May 2, 2026

Refactor

b98d700

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Abdulbois force-pushed the #724-URL-Reachability-Check branch from 42868dd to b98d700 Compare May 2, 2026 09:55

Fix dockerfiles

99c96d8

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Abdulbois force-pushed the #724-URL-Reachability-Check branch 3 times, most recently from 2555475 to 1e68fd2 Compare May 2, 2026 10:43

Fix CI file

45e70e3

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Abdulbois force-pushed the #724-URL-Reachability-Check branch from 1e68fd2 to 45e70e3 Compare May 2, 2026 11:26

Abdulbois added 3 commits May 4, 2026 12:33

Update Ubuntu version to resolve image incompatibility issue in githu…

3678b10

…b CI Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Disable URL liveness check for CI integration tests

014001f

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Refactor

13c3757

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Abdulbois force-pushed the #724-URL-Reachability-Check branch from 7584b83 to 13c3757 Compare May 4, 2026 10:37

Abdulbois and others added 3 commits May 7, 2026 11:37

Merge branch 'master' into zigbee-alliance#724-URL-Reachability-Check

ab462e7

Disable URL liveness checker in test

187548c

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Fix

97932b9

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

ashcherbakov requested changes May 8, 2026

View reviewed changes

Abdulbois added 4 commits May 9, 2026 14:14

Refactor URL liveness checks

86daf85

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Update CI and Make files to run URL liveness checks

3ecb037

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Fix if conditions

ae9c4dc

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Revert golang image version change

4056ef4

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

ashcherbakov reviewed May 11, 2026

View reviewed changes

Enable checker in missed places

9e47934

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

AzizMukhtorjonov requested changes May 13, 2026

View reviewed changes

Abdulbois added 2 commits May 14, 2026 16:43

Improve namings and impl

2d8fc46

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Fix typo

68b35e1

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>

Abdulbois requested review from AzizMukhtorjonov and ashcherbakov May 14, 2026 11:45

		@@ -49,27 +53,78 @@ func requiredIfBit0Set(fl validator.FieldLevel) bool {
		}

		func isValidHttpOrHttpsUrl(fl validator.FieldLevel) bool { //nolint:stylecheck

	GOCOVER_MODE: set # Ensure integration tests use the same mode as unit tests\
	GOCOVER_MODE: set # Ensure integration tests use the same mode as unit tests

Conversation

Abdulbois commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Abdulbois May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Abdulbois May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Abdulbois May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Abdulbois commented May 2, 2026 •

edited

Loading

Abdulbois May 9, 2026 •

edited

Loading

Abdulbois May 14, 2026 •

edited

Loading

Abdulbois May 14, 2026 •

edited

Loading