#704 Add more tests to increase test coverage#755
Merged
AzizMukhtorjonov merged 17 commits intoJul 6, 2026
Merged
Conversation
Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
… offline tests, and clean up unused code. Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
… into coverage report. Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
…overage threshold to 90%, and update dependencies. Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
…script. Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
…er with non-CRL `DataFields`. Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
…catesBySubject` with offline and error scenarios. Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
…rs with extensive negative scenarios. Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
…ve scenarios, including invalid certificates, self-signed CRLs, and mismatched model versions. Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
…9Cert`, and validator handlers with additional edge and negative scenarios. Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
…ve scenarios involving invalid parent certificates. Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
ashcherbakov
reviewed
Jul 6, 2026
|
|
||
| func TestSetLastValidatorPower_PanicsOnInvalidOwner(t *testing.T) { | ||
| k, ctx := testkeeper.ValidatorKeeper(t, nil) | ||
| require.Panics(t, func() { |
Contributor
There was a problem hiding this comment.
Not sure we should expect Panic here....
Collaborator
Author
There was a problem hiding this comment.
It should panic on invalid bech32 address, see SetLastValidatorPower (last_validator_power.go:14-17)
Contributor
There was a problem hiding this comment.
Does it mean there are cases when we expect our node to crash? Please double-check if the business logic is correct here
Collaborator
Author
There was a problem hiding this comment.
Business logic was built by following the cosmos-sdk(0.47.8) convention
Also, the SetLastValidatorPower second arg lastValidatorPower(LastValidatorPower) is constructed via types.NewLastValidatorPower(owner sdk.ValAddress), from already valid bech32 address
…dlers and tests Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
…nt_NonCRL_DataFields` and improve assertions for `VVSC chain verification failed` and handler responses in PKI, validator, and upgrade tests. Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
…g and update related tests and messages Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #704