collect module imports of public modules#3187
Merged
Techatrix merged 1 commit intozigtools:masterfrom Apr 27, 2026
Merged
Conversation
Currently, zls only collects module imports of Step.Compile. For public modules, it only collect the root_modules, not their module imports. This commit makes the build_runner also collects the module imports and also adds one regression test case when one does `addOptions` on a public module, which is my original motivation (and confusion why my @import("options") was not working). The generated options.zig file is generated in the c/ instead of o/ namespace, so I also removed the namespace assertion. I assume the original assertion is only for reminding reader of what that component is, and not an actual useful property of the path, so I keep the intent as a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, zls only collects module imports of Step.Compile. For public modules, it only collect the root_modules, not their module imports.
This commit makes the build_runner also collects the module imports and also adds one regression test case when one does
addOptionson a public module, which is my original motivation (and confusion why my@import("options")was not working).The generated options.zig file is generated in the
c/instead ofo/namespace, so I also removed the namespace assertion. I assume the original assertion is only for reminding reader of what that component is, and not an actual useful property of the path, so I keep the intent as a comment.Please let me know if this is the correct fix, or was there a reason
b.modulesare treated differently fromStep.Compile.Also, without the fix, the added test case with fail with: