fix: prevent renaming aliased functions during rename request#3189
Open
nikhilcodes777 wants to merge 1 commit intozigtools:masterfrom
Open
fix: prevent renaming aliased functions during rename request#3189nikhilcodes777 wants to merge 1 commit intozigtools:masterfrom
nikhilcodes777 wants to merge 1 commit intozigtools:masterfrom
Conversation
neoto
added a commit
to neoto/zls
that referenced
this pull request
May 2, 2026
Handles references to aliased decls more correctly by distinguishing between containers and runtime types. Compared to zigtools#3189 which special cases renames, this _should_ address the root cause, fixing both renaming and highlighting symbols. I also added regression tests. Closes zigtools#3184
neoto
added a commit
to neoto/zls
that referenced
this pull request
May 2, 2026
Handles references to aliased decls more correctly by distinguishing between containers and runtime types. Compared to zigtools#3189 which special cases renames, this _should_ address the root cause, fixing both renaming and highlighting symbols. I also added regression tests that fail without the changes on this branch. Closes zigtools#3184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3184
Description
This fixes an issue where triggering a
textDocument/renameon a local alias of a function (e.g.,const testName = std.debug.print;) would incorrectly resolve the alias to its source and rename the original declaration (e.g., renamingprintinside the Zig standard library).Root Cause:
During a rename request,
referencesHandlerand the reference-gatheringBuilderwere aggressively resolving aliases usinganalyser.resolveVarDeclAlias. While this is desired fortextDocument/referencesorhighlight, it results in cross-file destruction during a rename.Changes:
resolve_aliasesboolean flag to theBuilderstruct insrc/features/references.zig.resolveVarDeclAliasin bothreferencesHandlerandBuilder.referenceNodeifrequest == .rename.Environment / Tested On
zig 0.16.0zig 0.17.0-dev.215+8c5542bd3emacs/neovimTest Case Used