Merge pull request #311 from zigzagdev/chore/fix-property

fix: align list DTO with API thumbnail_url field

Author: zigzagdev

client/src/app/features/heritages/mappers/__tests__/to-world-heritage-vm.test.ts

@@ -24,7 +24,7 @@ const base: ApiWorldHeritageDto = {
   state_party: "JPN",
   state_party_codes: ["JPN"],
   state_parties_meta: { JPN: { is_primary: true, inscription_year: 1993 } },
-  thumbnail: "https://whc.unesco.org/document/209295/site_0661_0026.jpg",
+  thumbnail_url: "https://whc.unesco.org/document/209295/site_0661_0026.jpg",
 };
 
 describe("toWorldHeritageVm", () => {
@@ -59,7 +59,7 @@ describe("toWorldHeritageVm", () => {
       bufferText: "320 ha",
       statePartyCodes: ["日本"],
       statePartiesMeta: { JPN: { isPrimary: true, inscriptionYear: 1993 } },
-      thumbnailUrl: base.thumbnail,
+      thumbnailUrl: base.thumbnail_url,
       images: [],
     });
 
@@ -102,8 +102,8 @@ describe("toWorldHeritageVm", () => {
     expect(vm.bufferText).toBe("—");
   });
 
-  it("when thumbnail is null, thumbnailUrl is null", () => {
-    const vm = toWorldHeritageVm({ ...base, thumbnail: null }, "ja");
+  it("when thumbnail_url is null, thumbnailUrl is null", () => {
+    const vm = toWorldHeritageVm({ ...base, thumbnail_url: null }, "ja");
     expect(vm.thumbnailUrl).toBeNull();
   });
 

client/src/app/features/heritages/mappers/to-world-heritage-detail-vm.ts

@@ -34,7 +34,7 @@ export function toWorldHeritageDetailVm(
     state_party: dto.state_party,
     state_party_codes: dto.state_party_codes,
     state_parties_meta: dto.state_parties_meta,
-    thumbnail: dto.thumbnail_url,
+    thumbnail_url: dto.thumbnail_url,
   } satisfies import("../../../../domain/types.ts").ApiWorldHeritageDto;
 
   const base: WorldHeritageVm = toWorldHeritageVm(listDto, locale);

client/src/app/features/heritages/mappers/to-world-heritage-vm.ts

@@ -114,7 +114,7 @@ export function toWorldHeritageVm(data: ApiWorldHeritageDto, locale: Locale): Wo
     bufferText: fmtHa(data.buffer_zone_hectares),
     criteriaText: criteriaCodes.join(", "),
 
-    thumbnailUrl: data.thumbnail,
+    thumbnailUrl: data.thumbnail_url,
     images: [],
   };
 }

client/src/app/features/search/hooks/__tests__/use-search-heritage-query-test.ts

@@ -87,7 +87,7 @@ const OK: ApiSearchResponse = {
         unesco_site_url: "https://whc.unesco.org/en/list/661",
         state_party_codes: ["JPN"],
         state_parties_meta: { JPN: { is_primary: true, inscription_year: 1993 } },
-        thumbnail: null,
+        thumbnail_url: null,
       },
     ],
     pagination: { current_page: 1, per_page: 30, total: 1, last_page: 1 },

client/src/app/features/search/mapper/__tests__/to-world-heritage-vm.test.ts

@@ -41,7 +41,7 @@ const makeWorldHeritageDto = (
     state_party: null,
     state_party_codes: ["JP"],
     state_parties_meta: {},
-    thumbnail: null,
+    thumbnail_url: null,
   } satisfies ApiWorldHeritageDto;
 
   return { ...base, ...overrides };

client/src/app/features/top/apis/index.test.ts

@@ -48,7 +48,7 @@ const makeDto = (overrides: Partial<ApiWorldHeritageDto> = {}): ApiWorldHeritage
   state_party: null,
   state_party_codes: ["JPN"],
   state_parties_meta: {},
-  thumbnail: null,
+  thumbnail_url: null,
   ...overrides,
 });
 

client/src/domain/types.ts

@@ -63,7 +63,7 @@ export type ApiWorldHeritageDto = {
   state_party: string | null;
   state_party_codes: string[];
   state_parties_meta: StatePartiesMetaDto;
-  thumbnail: string | null;
+  thumbnail_url: string | null;
 };
 
 /**