From f0fa33dd4a8b970983b607e8a4db0a6d47d9e2b7 Mon Sep 17 00:00:00 2001 From: Application-drop-up Date: Wed, 22 Apr 2026 08:51:44 +0900 Subject: [PATCH 1/3] feat: add property shortDescriptionJp --- .../mappers/__tests__/to-world-heritage-detail-vm-test.ts | 3 ++- .../heritages/mappers/__tests__/to-world-heritage-vm.test.ts | 1 + .../features/heritages/mappers/to-world-heritage-detail-vm.ts | 1 + .../src/app/features/heritages/mappers/to-world-heritage-vm.ts | 1 + 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/client/src/app/features/heritages/mappers/__tests__/to-world-heritage-detail-vm-test.ts b/client/src/app/features/heritages/mappers/__tests__/to-world-heritage-detail-vm-test.ts index d38d756..715162c 100644 --- a/client/src/app/features/heritages/mappers/__tests__/to-world-heritage-detail-vm-test.ts +++ b/client/src/app/features/heritages/mappers/__tests__/to-world-heritage-detail-vm-test.ts @@ -41,6 +41,7 @@ const baseDto = ( area_hectares: 107, buffer_zone_hectares: 143, short_description: "dummy", + short_description_jp: "ダミー", unesco_site_url: "https://example.com", state_party: null, state_party_codes: ["JPN"], @@ -75,7 +76,7 @@ describe("toWorldHeritageDetailVm", () => { expect(vm.countryNameJp).toBe(dto.country_name_jp); expect(vm.region).toBe(dto.region); - // detail 差分 + // detail expect(vm.primaryStatePartyCode).toBe("JPN"); expect(vm.thumbnailUrl).toBe(dto.thumbnail_url); diff --git a/client/src/app/features/heritages/mappers/__tests__/to-world-heritage-vm.test.ts b/client/src/app/features/heritages/mappers/__tests__/to-world-heritage-vm.test.ts index 2d5bf36..da79ac7 100644 --- a/client/src/app/features/heritages/mappers/__tests__/to-world-heritage-vm.test.ts +++ b/client/src/app/features/heritages/mappers/__tests__/to-world-heritage-vm.test.ts @@ -47,6 +47,7 @@ describe("toWorldHeritageVm", () => { latitude: null, longitude: null, shortDescription: "desc", + shortDescriptionJp: "ダミー", unescoSiteUrl: "https://whc.unesco.org/en/list/663", primaryStatePartyCode: null, criteriaText: "ix, x", diff --git a/client/src/app/features/heritages/mappers/to-world-heritage-detail-vm.ts b/client/src/app/features/heritages/mappers/to-world-heritage-detail-vm.ts index fc491f6..8e126e8 100644 --- a/client/src/app/features/heritages/mappers/to-world-heritage-detail-vm.ts +++ b/client/src/app/features/heritages/mappers/to-world-heritage-detail-vm.ts @@ -25,6 +25,7 @@ export function toWorldHeritageDetailVm(dto: ApiWorldHeritageDetailDto): WorldHe area_hectares: dto.area_hectares, buffer_zone_hectares: dto.buffer_zone_hectares, short_description: dto.short_description, + short_description_jp: dto.short_description_jp, unesco_site_url: dto.unesco_site_url, state_party: dto.state_party, state_party_codes: dto.state_party_codes, diff --git a/client/src/app/features/heritages/mappers/to-world-heritage-vm.ts b/client/src/app/features/heritages/mappers/to-world-heritage-vm.ts index cb9d7a0..3cf3b80 100644 --- a/client/src/app/features/heritages/mappers/to-world-heritage-vm.ts +++ b/client/src/app/features/heritages/mappers/to-world-heritage-vm.ts @@ -80,6 +80,7 @@ export function toWorldHeritageVm(data: ApiWorldHeritageDto): WorldHeritageVm { latitude: data.latitude, longitude: data.longitude, shortDescription: data.short_description, + shortDescriptionJp: data.short_description_jp, unescoSiteUrl: data.unesco_site_url, statePartyCodes: statePartyLabelsJp, statePartiesMeta: normalizeStatePartiesMeta(data.state_parties_meta), From cc999e3268d640649b0650cc3176da25ee37d9d5 Mon Sep 17 00:00:00 2001 From: Application-drop-up Date: Wed, 22 Apr 2026 09:02:10 +0900 Subject: [PATCH 2/3] chore: update tsconfig.json --- client/tsconfig.app.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/tsconfig.app.json b/client/tsconfig.app.json index 1ce38e9..ecd9a4d 100644 --- a/client/tsconfig.app.json +++ b/client/tsconfig.app.json @@ -10,7 +10,7 @@ "@features/*": ["app/features/*"] }, "module": "ESNext", - "types": ["vite/client", "jest"], + "types": ["vite/client", "jest", "@testing-library/jest-dom"], "skipLibCheck": true, "moduleResolution": "bundler", "allowImportingTsExtensions": true, From 09b099a04d89d26c3e0a05593899d02eb5e633b9 Mon Sep 17 00:00:00 2001 From: Application-drop-up Date: Wed, 22 Apr 2026 09:03:23 +0900 Subject: [PATCH 3/3] chore: add new Property to Hooks --- .../top/hooks/__tests__/use-world-heritage-detail.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/client/src/app/features/top/hooks/__tests__/use-world-heritage-detail.test.ts b/client/src/app/features/top/hooks/__tests__/use-world-heritage-detail.test.ts index 32bf129..8b8b826 100644 --- a/client/src/app/features/top/hooks/__tests__/use-world-heritage-detail.test.ts +++ b/client/src/app/features/top/hooks/__tests__/use-world-heritage-detail.test.ts @@ -97,6 +97,7 @@ describe("useWorldHeritageDetail", () => { area_hectares: null, buffer_zone_hectares: null, short_description: "A group of historic sites in Kyoto.", + unesco_site_url: "https://example.com/kyoto", state_party: "Japan", state_party_codes: ["JPN"],