Refactor/use locale context in detail#301
Merged
zigzagdev merged 4 commits intochore/create-language-contextfrom Apr 30, 2026
Merged
Refactor/use locale context in detail#301zigzagdev merged 4 commits intochore/create-language-contextfrom
zigzagdev merged 4 commits intochore/create-language-contextfrom
Conversation
feat: add LocaleProvider with URL synced locale state
Drop the named LocaleContextType alias and pass the shape directly to createContext, keeping the .tsx file free of named type declarations. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drop the URL-derived locale plumbing in WorldHeritageDetailContainer and the locale/toggleLocale props on HeritageDetailLayout, HeritageHero, and HeritageOverViewSection. Each component now reads locale from useLocale(), so the container only forwards item and the detail tree no longer prop-drills locale state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The earlier consumer migration removed the locale prop from HeritageOverViewSection but left the call site still passing it, breaking the CI typecheck. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorldHeritageDetailContainerand thelocale/toggleLocaleprops onHeritageDetailLayout,HeritageHero, andHeritageOverViewSection; each component now reads locale fromuseLocale().LocaleContextTypealias on thecreateContextcall soLocaleProvider.tsxcarries no named type declaration.LocaleProviderimport path (../../domain/criteria.ts) that broke after the move undersrc/shared/locale/.Test plan