Chore: Add criteria & endangered selector into search form#310
Merged
Chore: Add criteria & endangered selector into search form#310
Conversation
…rip) Add is_endangered to HeritageSearchParams and SearchValues, default it to null/false, parse and serialize the URL query param, and round-trip the value through the form / result containers and the detail layout's quick-submit. The form's internal state initialiser, the detail layout's DEFAULT_SEARCH, and the search container test mocks are updated to satisfy the new field. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Place a LocaleToggle next to "Back to all sites" so users can switch locales from the search results page itself, and read the button text plus the empty-state message from useText. The h1 brand "Search Results" and the subtitle stay untranslated by design. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…chParams literals Two literals in test code and the detail-side HeritageSubHeader were missed when is_endangered was added to the types, breaking CI typecheck. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Feat/search endangered filter
… round-trip) Add criteria: CriteriaCode[] to HeritageSearchParams and SearchValues, default it to [], and parse/serialize the URL as a comma-separated list (criteria=ii,iv) — invalid codes are dropped, duplicates collapsed, and the resulting array is sorted in CRITERIA canonical order. The form / result containers, detail layout, both HeritageSubHeaders, and the test helpers are updated to satisfy the new field. Empty array stays out of the URL. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Render the i–x criteria as multi-toggle chips between the Category row and the Endangered checkbox. Clicking a chip adds or removes the code from the selection (kept in CRITERIA canonical order); the heading reuses the existing text.criteria key. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Chore: multi-select filter (i–x) to the heritage search form
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.