feat: enlarge gallery images in a Lightbox with prev/next navigation#390
Merged
Conversation
Add a fullscreen overlay with a close button as the foundation for the gallery image enlargement view. Image rendering is added next.
Display the enlarged image with its alt text and optional credit inside the overlay added previously.
Add lightboxImage state to HeritageDetailLayout and connect HeritageGallery's onSelectImage to it, rendering the Lightbox so clicking a gallery thumbnail enlarges the image.
Improve usability by letting users dismiss the enlarged image via keyboard or by clicking the overlay backdrop, not just the close button.
Lightbox is only used for enlarging gallery images on the heritage detail page, so it doesn't belong in the generic shared UI primitives directory.
Switch HeritageGallery's onSelectImage to pass the clicked image's index instead of its data, and have Lightbox track the current index within the full image list. This lets users navigate to the next or previous photo with on-screen arrows (or Left/Right arrow keys) without closing the Lightbox.
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HeritageGallery's thumbnail click to open the Lightbox on the clicked imageCloses #391 (supersedes #142, #144 — pivoted from hero-image-swap to a Lightbox enlarge pattern)
Test plan