feat: replace plain-text loading states with a Spinner component#393
Merged
Conversation
Add a centered spinning-circle component to replace the plain "Loading…" text currently shown across the top, detail, and search results pages.
Replace the plain-text "Loading…" paragraph with the Spinner component.
Replace the plain-text "Loading…" div with the Spinner component.
Previously the loading state rendered the full SearchResultsPage shell with rangeText="Loading…", which could misleadingly show the "no sites found" empty state while a request was in flight. Render the Spinner standalone alongside the search header instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spinnercomponent (centered, animated circle via Tailwindanimate-spin) toshared/uis/rangeText="Loading…"intoSearchResultsPage, since that could misleadingly show the "no sites found" empty state while a request was still in flightCloses #379
Test plan