fix: wire up the Gallery See all button to a dedicated gallery page#404
Open
zigzagdev wants to merge 4 commits into
Open
fix: wire up the Gallery See all button to a dedicated gallery page#404zigzagdev wants to merge 4 commits into
zigzagdev wants to merge 4 commits into
Conversation
Renders the full photo grid for a heritage site (no preview cap) and reuses the existing Lightbox for prev/next viewing.
Fetches the heritage detail by :id and feeds full image list and Lightbox state to HeritageGalleryPage.
HeritageGallery's "See all" button rendered but did nothing because onOpenGallery was never passed from HeritageDetailLayout. It now navigates to the new full gallery page. Closes #403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HeritageGallery's "See all" button rendered whenever a site has more than 6 photos, butHeritageDetailLayoutnever passed anonOpenGalleryhandler — clicking it did nothing, so users could never view photos beyond the 6-photo preview grid./heritages/:id/gallery(path param, since it's a sub-resource of a specific heritage site) showing the complete photo grid, reusing the existingLightboxfor prev/next viewing.HeritageGallery'sonOpenGalleryinHeritageDetailLayoutto navigate there.Changes
feat(gallery): addHeritageGalleryPage(full photo grid + Lightbox)feat(gallery): addHeritageGalleryContainer(fetches heritage detail by:id) + testsfeat(routes): wire/heritages/:id/galleryintoAppRoutesfix(gallery): wire the "See all" button to navigate thereCloses #403
Test plan
tsc --noEmitpassesjest— 19 suites / 100 tests passing (4 new tests forHeritageGalleryContainer)