feat: add elastic search wrapper#509
feat: add elastic search wrapper#509AvikantSrivastava wants to merge 1 commit intozilliztech:devfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AvikantSrivastava The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| def rebuild(self, ids=None) -> bool: | ||
| pass | ||
|
|
There was a problem hiding this comment.
@SimFG @cxie @xiaofan-luan
do we need a rebuild method for Elastic Search?
There was a problem hiding this comment.
If the index can be updated as the data changes, rebuild does not need to be implemented. If not, say faiss, you need to implement
| top_k: int = 1, | ||
| namespace: str = "", | ||
| ): | ||
| self._client = Elasticsearch("http://localhost:9200") |
There was a problem hiding this comment.
@SimFG @cxie @xiaofan-luan
I am currently running a local docker image of elastic search. What should be the hostname for the production use cases here?
Also, a point to note, I have used a http URL since, TLS was required to use a https with Elastic Search
There was a problem hiding this comment.
Perhaps through a variable, let the user pass the url parameter by himself. The default value of the parameter is: "http://localhost:9200"
|
@AvikantSrivastava please make the dev branch as the target branch |
done |
|
@AvikantSrivastava hi, you need to check the failed process, like pylint and unit test, and add some unit test cases for the elastic search vector store. |
3 participants
No description provided.