Skip to content

add num_shards to MilvusConfig.to_dict()#538

Merged
alwayslove2013 merged 1 commit intozilliztech:mainfrom
ZebinRen:fix-milvus-config-issue
Jun 11, 2025
Merged

add num_shards to MilvusConfig.to_dict()#538
alwayslove2013 merged 1 commit intozilliztech:mainfrom
ZebinRen:fix-milvus-config-issue

Conversation

@ZebinRen
Copy link
Copy Markdown
Contributor

In #526 an argument num_shards is added to milvus, however, this argument is not included in the to_dict() function of MilvusConfig, leading to an error at line

num_shards=self.db_config.get("num_shards"),
.

@sre-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alwayslove2013, ZebinRen
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alwayslove2013 alwayslove2013 merged commit 2391393 into zilliztech:main Jun 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants