Fix: Use sql.SQL() for pgvector access method names to fix "HNSW does not exist" error#762
Closed
NagarajuReddyBoggala wants to merge 1 commit intozilliztech:mainfrom
Closed
Conversation
- Changed index_type parameter from sql.Identifier to sql.SQL - PostgreSQL access methods (hnsw, ivfflat) should not be quoted identifiers - Fixes zilliztech#759: 'access method HNSW does not exist' error
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NagarajuReddyBoggala The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
/assign @XuanYang-cn |
Collaborator
|
I think this is a dup with #760 and the #759 was fixed, I'm going to close this PR @NagarajuReddyBoggala Thanks for the contribution again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PGVector HNSW index creation fails with:
This happens through the WebUI but works via CLI.
Root Cause
In
pgvector.pylines 363 and 378, the index_type is wrapped withsql.Identifier(), which PostgreSQL treats as a quoted identifier. PostgreSQL access methods must NOT be quoted.Solution
Changed
sql.Identifier(index_param["index_type"])tosql.SQL(index_param["index_type"])This generates proper SQL:
USING "hnsw"❌USING hnsw✅Fixes
Closes #759