From e9a3e2e966adbf6b4df35e61309d3f9f380f3bc9 Mon Sep 17 00:00:00 2001
From: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Date: Wed, 22 Apr 2026 06:53:51 -0700
Subject: [PATCH] fix(mcp): drop unreachable throw in setTimeout-wrapped
 initial sync

The throw inside an async setTimeout callback has no caller to propagate
to, so unexpected errors during the 5s-deferred initial sync are silently
lost anyway. The preceding console.error already covers observability.

Fixes #256
---
 packages/mcp/src/sync.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/mcp/src/sync.ts b/packages/mcp/src/sync.ts
index 0f53bab8..8370b643 100644
--- a/packages/mcp/src/sync.ts
+++ b/packages/mcp/src/sync.ts
@@ -126,7 +126,7 @@ export class SyncManager {
                     console.log('[SYNC-DEBUG] Collection not yet established, this is expected for new cluster users. Will retry on next sync cycle.');
                 } else {
                     console.error('[SYNC-DEBUG] Initial sync failed with unexpected error:', error);
-                    throw error;
+                    // Do not re-throw here: this callback runs via setTimeout with no caller to propagate to.
                 }
             }
         }, 5000); // Initial sync after 5 seconds