You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for adding this. The model support itself is useful, but I think the batch behavior needs one change before we merge this.
I tested the current Google GenAI SDK with a real Gemini API key, and gemini-embedding-2 accepts array input through models.embedContent and returns one embedding per input:
gemini-embedding-2 single ok embeddings=1 dim=768
gemini-embedding-2 array ok embeddings=2 dims=768,768
Because of that, we should not mark gemini-embedding-2 as supportsBatchEmbedding: false or force it to embed each chunk one by one. That would make large codebase indexing much slower by increasing the number of API calls.
Could you update this PR to keep the existing batched request path for gemini-embedding-2, and limit the change to adding the model metadata, docs, and regression tests? The response-count validation and empty-batch handling are good additions and can stay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Fixes #365