fix: add Milvus search result validation with actionable diagnostics#403
Open
afadhitya wants to merge 1 commit into
Open
fix: add Milvus search result validation with actionable diagnostics#403afadhitya wants to merge 1 commit into
afadhitya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #393
Summary
Add
VectorSearchResultValidationErrorandvalidateMilvusSearchResultRow()to guard against null Milvus search results that causedsearch_codeto fail with "Cannot read properties of null (reading 'scores')" even after successful indexing.Changes
Core package
search-result-validation.ts— new validation utility:VectorSearchResultValidationErrorerror class +validateMilvusSearchResultRow()with actionable diagnosticsmilvus-vectordb.ts— validate result rows in both regular and hybrid search before mapping scoresmilvus-restful-vectordb.ts— same validation in RESTful client (both search + hybrid search)context.ts— log embedding provider, expected dimension, and actual query dimension during search to surface mismatches earlyvectordb/index.ts— export new validation symbolssearch-result-validation.test.ts— 3 tests (null row, missing score, valid)milvus-vectordb.search-validation.test.ts— 2 tests (null result, null score)context.search-dimensions.test.ts— 1 test (dimension logging)MCP package
handlers.ts— catchVectorSearchResultValidationErrorand return actionable error message (dimension mismatch, collection mismatch, etc.) instead of generic "check if indexed"handlers.search-validation.test.ts— 1 test (actionable diagnostics)Verification