diff --git a/include/knowhere/version.h b/include/knowhere/version.h index 244d5b66c..108630870 100644 --- a/include/knowhere/version.h +++ b/include/knowhere/version.h @@ -22,6 +22,7 @@ namespace { static constexpr int32_t default_version = 0; static constexpr int32_t minimal_version = 0; static constexpr int32_t current_version = 6; +static constexpr int32_t maximum_version = 7; } // namespace class Version { @@ -35,12 +36,18 @@ class Version { return Version(default_version); } - // the current version (newest version support) + // the recommended version static inline Version GetCurrentVersion() { return Version(current_version); } + // the maximum version (beta version) + static inline Version + GetMaximumVersion() { + return Version(maximum_version); + } + // the minimal version (oldest version support) static inline Version GetMinimalVersion() { @@ -49,12 +56,12 @@ class Version { static inline bool VersionSupport(const Version& version) { - return GetMinimalVersion() <= version && version <= GetCurrentVersion(); + return GetMinimalVersion() <= version && version <= GetMaximumVersion(); } static inline std::pair GetSupportRange() { - return std::make_pair(Version(minimal_version), Version(current_version)); + return std::make_pair(Version(minimal_version), Version(maximum_version)); } // the version number diff --git a/tests/ut/test_utils.cc b/tests/ut/test_utils.cc index ec23e0d17..92b8c081e 100644 --- a/tests/ut/test_utils.cc +++ b/tests/ut/test_utils.cc @@ -149,6 +149,9 @@ TEST_CASE("Test Version") { REQUIRE(knowhere::Version::VersionSupport(knowhere::Version::GetDefaultVersion())); REQUIRE(knowhere::Version::VersionSupport(knowhere::Version::GetMinimalVersion())); REQUIRE(knowhere::Version::VersionSupport(knowhere::Version::GetCurrentVersion())); + REQUIRE(knowhere::Version::VersionSupport(knowhere::Version::GetMaximumVersion())); + REQUIRE(knowhere::Version::GetMinimalVersion() <= knowhere::Version::GetCurrentVersion()); + REQUIRE(knowhere::Version::GetCurrentVersion() <= knowhere::Version::GetMaximumVersion()); } TEST_CASE("Test DiskLoad") {