Skip to content

enhance: add maximum version #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sre-ci-robot merged 1 commit into from
Apr 17, 2025
Merged

enhance: add maximum version #1153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions include/knowhere/version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ namespace {
static constexpr int32_t default_version = 0;
static constexpr int32_t minimal_version = 0;
static constexpr int32_t current_version = 6;
static constexpr int32_t maximum_version = 7;
} // namespace

class Version {
Expand All @@ -35,12 +36,18 @@ class Version {
return Version(default_version);
}

// the current version (newest version support)
// the recommended version
static inline Version
GetCurrentVersion() {
return Version(current_version);
}

// the maximum version (beta version)
static inline Version
GetMaximumVersion() {
return Version(maximum_version);
}

// the minimal version (oldest version support)
static inline Version
GetMinimalVersion() {
Expand All @@ -49,12 +56,12 @@ class Version {

static inline bool
VersionSupport(const Version& version) {
return GetMinimalVersion() <= version && version <= GetCurrentVersion();
return GetMinimalVersion() <= version && version <= GetMaximumVersion();
}

static inline std::pair<Version, Version>
GetSupportRange() {
return std::make_pair(Version(minimal_version), Version(current_version));
return std::make_pair(Version(minimal_version), Version(maximum_version));
}

// the version number
Expand Down
3 changes: 3 additions & 0 deletions tests/ut/test_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ TEST_CASE("Test Version") {
REQUIRE(knowhere::Version::VersionSupport(knowhere::Version::GetDefaultVersion()));
REQUIRE(knowhere::Version::VersionSupport(knowhere::Version::GetMinimalVersion()));
REQUIRE(knowhere::Version::VersionSupport(knowhere::Version::GetCurrentVersion()));
REQUIRE(knowhere::Version::VersionSupport(knowhere::Version::GetMaximumVersion()));
REQUIRE(knowhere::Version::GetMinimalVersion() <= knowhere::Version::GetCurrentVersion());
REQUIRE(knowhere::Version::GetCurrentVersion() <= knowhere::Version::GetMaximumVersion());
}

TEST_CASE("Test DiskLoad") {
Expand Down
Loading