Skip to content

knowhere support riscv#1160

Merged
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
lyd1992:main
Apr 17, 2025
Merged

knowhere support riscv#1160
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
lyd1992:main

Conversation

@lyd1992
Copy link
Copy Markdown
Contributor

@lyd1992 lyd1992 commented Apr 17, 2025

image
image

This update introduces RISC-V 64 architecture recognition in the build system by adding dedicated macro detection (__riscv) to the CMake configuration file, while improving error diagnostics to clearly indicate riscv64 as a supported platform. These modifications ensure proper architecture validation and prevent accidental builds on unsupported platforms, laying foundational support for future RISC-V-specific optimizations like SIMD implementations.

Signed-off-by: yudong <yudong@njis.ac.cn>
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 17, 2025

@lyd1992 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@alexanderguzhva
Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, lyd1992

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexanderguzhva
Copy link
Copy Markdown
Collaborator

issue: #1161

@alexanderguzhva
Copy link
Copy Markdown
Collaborator

/kind improvement

@sre-ci-robot sre-ci-robot merged commit af2611d into zilliztech:main Apr 17, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants