Add refine for RaBitQ#1162
Conversation
|
issue: #1137 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
============================
============================
🚀 New features to boost your workflow:
|
|
/hold |
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
alexanderguzhva
force-pushed
the
ivfrabitq_refine
branch
from
999bd88 to
9c29f68
Compare
|
/unhold |
|
/hold |
|
/unhold |
| .description("whether the refine is used during the train") | ||
| .set_default(false) | ||
| .for_train() | ||
| .for_static(); |
There was a problem hiding this comment.
This naming is prone to ambiguity, whether it is possible to consider refine_ratio
| bool | ||
| WhetherAcceptableRefineType(const std::string& refine_type) { | ||
| // 'flat' is identical to 'fp32' | ||
| std::vector<std::string> allowed_list = {"sq6", "sq8", "fp16", "bf16", "fp32", "flat"}; |
There was a problem hiding this comment.
Just a question, do we support SQ4 now？
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
also, some refactoring
/kind improvement