Skip to content

fix: optimize boolean config parsing in json#1186

Merged
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
foxspy:fix_boolean_config
May 13, 2025
Merged

fix: optimize boolean config parsing in json#1186
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
foxspy:fix_boolean_config

Conversation

@foxspy
Copy link
Copy Markdown
Collaborator

@foxspy foxspy commented May 12, 2025

@mergify
Copy link
Copy Markdown

mergify Bot commented May 12, 2025

@foxspy 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
@foxspy foxspy force-pushed the fix_boolean_config branch from 7d58b23 to 0a103ee Compare May 13, 2025 08:18
@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@presburger
Copy link
Copy Markdown

/lgtm

@foxspy
Copy link
Copy Markdown
Collaborator Author

foxspy commented May 13, 2025

/kind improvement

@sre-ci-robot sre-ci-robot merged commit b016fc0 into zilliztech:main May 13, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants