Skip to content

sparse: add StaticHasRawData support#1188

Merged
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
sparknack:sparse-raw-data
May 14, 2025
Merged

sparse: add StaticHasRawData support#1188
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
sparknack:sparse-raw-data

Conversation

@sparknack
Copy link
Copy Markdown
Collaborator

@sparknack sparknack commented May 13, 2025

issue: #1194

@mergify
Copy link
Copy Markdown

mergify Bot commented May 13, 2025

@sparknack 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@zhengbuqian
Copy link
Copy Markdown
Collaborator

lgtm but ci failed at test_index_check.cc:212.

@foxspy why mergify bot still added ci-passed label?

Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
Copy link
Copy Markdown
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, sparknack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sparknack
Copy link
Copy Markdown
Collaborator Author

issue: #1194

@sparknack
Copy link
Copy Markdown
Collaborator Author

/kind improvement

@sre-ci-robot sre-ci-robot merged commit 725c197 into zilliztech:main May 14, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants