Skip to content

sparse: add some prometheus metrics for sparse#1202

Merged
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
sparknack:sparse-prometheus
May 26, 2025
Merged

sparse: add some prometheus metrics for sparse#1202
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
sparknack:sparse-prometheus

Conversation

@sparknack

Copy link
Copy Markdown
Collaborator

No description provided.

@mergify

mergify Bot commented May 22, 2025

Copy link
Copy Markdown

@sparknack 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@sparknack sparknack force-pushed the sparse-prometheus branch 2 times, most recently from 2166794 to fa96fab Compare May 22, 2025 02:36
@mergify mergify Bot added the ci-passed label May 22, 2025
@alexanderguzhva

Copy link
Copy Markdown
Collaborator

/lgtm

@sparknack

Copy link
Copy Markdown
Collaborator Author

/hold

@sparknack

Copy link
Copy Markdown
Collaborator Author

issue: #1204

@sparknack

Copy link
Copy Markdown
Collaborator Author

/kind improvement

@sparknack

Copy link
Copy Markdown
Collaborator Author

/unhold

@sparknack sparknack force-pushed the sparse-prometheus branch from c57eb5c to 5e68233 Compare May 26, 2025 02:12
@mergify mergify Bot removed the ci-passed label May 26, 2025
@sparknack sparknack force-pushed the sparse-prometheus branch 2 times, most recently from 880b273 to 07adbdd Compare May 26, 2025 02:28
@mergify mergify Bot removed the needs-dco label May 26, 2025
@sparknack sparknack force-pushed the sparse-prometheus branch from 07adbdd to 9629516 Compare May 26, 2025 02:32
Add three prometheus metrics for sparse inverted index, including:

- sparse dataset nnz histgram
- sparse inverted index posting list length histgram
- sparse inverted index size

Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
@foxspy

foxspy commented May 26, 2025

Copy link
Copy Markdown
Collaborator

/lgtm

@foxspy foxspy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, sparknack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 33e13f3 into zilliztech:main May 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants