Introduce Intel SVS 0.3.0#1537
Conversation
|
@alexanderguzhva 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
alexanderguzhva
force-pushed
the
svs_v0
branch
2 times, most recently
from
fee491a to
7a9aedc
Compare
|
/kind improvement |
related PRs: * zilliztech/VectorDBBench#749 for vectordbbench * zilliztech/knowhere#1537 for knowhere * #48798 for Milvus 3.0 Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
| // is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| // or implied. See the License for the specific language governing permissions and limitations under the License. | ||
|
|
||
| #ifdef KNOWHERE_WITH_SVS |
There was a problem hiding this comment.
What is the intended purpose of this conditional compilation? Unless there is a specific reason otherwise, new indices should be enabled by default.
There was a problem hiding this comment.
Got it, so it's x86 only for now. Any plans for ARM support on the roadmap?
There was a problem hiding this comment.
The public version is x86 only and only for Intel CPUs.
There was a problem hiding this comment.
SVS runs on ARM as well, including sqi8 quantization. However, LVQ and LeanVec run only on Intel.
| endif() | ||
|
|
||
| target_link_libraries(knowhere PUBLIC ${KNOWHERE_LINKER_LIBS}) | ||
| target_link_libraries(knowhere PRIVATE ${KNOWHERE_LINKER_LIBS}) |
There was a problem hiding this comment.
What was the motivation for this change?
|
rebased to master |
|
/rerun-e2e |
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
|
issue: #1585 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Introduces Intel SVS based index