Skip to content

fix: GetEmbListByIds support for MUVERA/LEMUR and DiskANN MAX_SIM metrics#1564

Merged
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
SpadeA-Tang:fix-get-emblist
Apr 14, 2026
Merged

fix: GetEmbListByIds support for MUVERA/LEMUR and DiskANN MAX_SIM metrics#1564
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
SpadeA-Tang:fix-get-emblist

Conversation

@SpadeA-Tang

@SpadeA-Tang SpadeA-Tang commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

issue: #1499

BTW, ban non-fp32 for muvera/lemur as it's not ready.

@mergify

mergify Bot commented Apr 8, 2026

Copy link
Copy Markdown

@SpadeA-Tang 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@alexanderguzhva

Copy link
Copy Markdown
Collaborator

looks good overall. Unit tests need to be fixed.

@SpadeA-Tang

Copy link
Copy Markdown
Contributor Author

staticConfigCheckMap[indexType] = VecIndexNode::StaticConfigCheck; is dead code, which leads to UT failed. Wait it to be fiexed.

@alexanderguzhva

Copy link
Copy Markdown
Collaborator

@SpadeA-Tang is this PR related to #1571?

@SpadeA-Tang

Copy link
Copy Markdown
Contributor Author

@SpadeA-Tang is this PR related to #1571?

yes

@SpadeA-Tang

Copy link
Copy Markdown
Contributor Author

@alexanderguzhva PTAL again, thanks.

@SpadeA-Tang
SpadeA-Tang force-pushed the fix-get-emblist branch 2 times, most recently from 3480a45 to 0af1623 Compare April 10, 2026 10:11
Signed-off-by: SpadeA <tangchenjie1210@gmail.com>
@alexanderguzhva

Copy link
Copy Markdown
Collaborator

/kind improvement
issue: #1499

@alexanderguzhva

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@sre-ci-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, SpadeA-Tang, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alexanderguzhva,zhengbuqian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
sre-ci-robot merged commit 2b56087 into zilliztech:main Apr 14, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants