fix: GetEmbListByIds support for MUVERA/LEMUR and DiskANN MAX_SIM metrics#1564
Conversation
|
@SpadeA-Tang 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
b772f2f to
708d98d
Compare
|
looks good overall. Unit tests need to be fixed. |
|
|
708d98d to
6bc1b69
Compare
|
@SpadeA-Tang is this PR related to #1571? |
yes |
|
@alexanderguzhva PTAL again, thanks. |
3480a45 to
0af1623
Compare
Signed-off-by: SpadeA <tangchenjie1210@gmail.com>
0af1623 to
76e3cf5
Compare
|
/kind improvement |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva, SpadeA-Tang, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #1499
BTW, ban non-fp32 for muvera/lemur as it's not ready.