fix: rename remaining KNOHWERE_DECLARE_CONFIG sites in svs_config.h#1593
Merged
sre-ci-robot merged 1 commit intoApr 20, 2026
Merged
Conversation
PR zilliztech#1577 renamed the macro definition KNOHWERE_DECLARE_CONFIG -> KNOWHERE_DECLARE_CONFIG in include/knowhere/config.h and updated most in-tree callers, but missed the three call sites in src/index/svs/svs_config.h. The breakage is silent today because WITH_SVS defaults to OFF in CMakeLists.txt, so PR-CI never compiles this file; it would only surface for downstream consumers building with -DWITH_SVS=ON. Rename the three call sites to match. The same typo also exists in cardinal's vendored headers; that is fixed separately in zilliztech/cardinal#823. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: foxspy, jamesgao-jpg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename the three call sites of the typo'd macro
KNOHWERE_DECLARE_CONFIGinsrc/index/svs/svs_config.h(SvsVamanaConfig,SvsVamanaLvqConfig,SvsVamanaLeanVecConfig) to the correct spellingKNOWHERE_DECLARE_CONFIG.Why
PR #1577 (commit c884fd8) renamed the macro definition in
include/knowhere/config.h:It updated most in-tree call sites but missed the three uses in
svs_config.h. The breakage is silent today becauseCMakeLists.txt:37defaultsWITH_SVStoOFF, so PR-CI never compiles this file. It would surface as soon as anyone builds with-DWITH_SVS=ON.The same typo also exists in the cardinal-side vendored headers (
know/cardinal_config.h,know/cardinal_cluster_config.h); that already broke the knowhere/nightly-2.0 Jenkins job from build #822 onward and is fixed in zilliztech/cardinal#823. This PR is just the matching cleanup on the knowhere side.Test
pre-commit run --files src/index/svs/svs_config.h— passes (clang-format clean).