Skip to content

Remove fork SQ in favor of vanilla FAISS version#1594

Merged
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
alexanderguzhva:remove_fork_sq
Apr 28, 2026
Merged

Remove fork SQ in favor of vanilla FAISS version#1594
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
alexanderguzhva:remove_fork_sq

Conversation

@alexanderguzhva
Copy link
Copy Markdown
Collaborator

@alexanderguzhva alexanderguzhva commented Apr 20, 2026

this should be supported by baseline PR facebookresearch/faiss#5128, which introduces RVV SQ in the vanilla faiss

Removes fork ScalarQuantizer facilities and uses the ones from the baseline

@mergify mergify Bot added the dco-passed label Apr 20, 2026
@alexanderguzhva alexanderguzhva force-pushed the remove_fork_sq branch 2 times, most recently from 3425441 to 71d071e Compare April 20, 2026 16:21
@alexanderguzhva alexanderguzhva changed the title Remove fork sq [WIP] Remove fork sq Apr 20, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 20, 2026

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@alexanderguzhva alexanderguzhva changed the title [WIP] Remove fork sq [Do not merge yet] Remove fork sq Apr 20, 2026
@alexanderguzhva alexanderguzhva changed the title [Do not merge yet] Remove fork sq Remove fork SQ in favor of vanilla FAISS version Apr 21, 2026
@alexanderguzhva
Copy link
Copy Markdown
Collaborator Author

issue: #1501
/kind improvement

Comment thread thirdparty/faiss/faiss/cppcontrib/knowhere/impl/sq-avx2-fastpath.cpp Outdated
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
@mergify mergify Bot added the ci-passed label Apr 27, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 28, 2026

@alexanderguzhva e2e jenkins job failed, comment /run-e2e-sse can trigger the job again.

Copy link
Copy Markdown
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alexanderguzhva,foxspy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2d9d473 into zilliztech:main Apr 28, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants