Skip to content

fix(svs): allow all-clear SVS_FLAT bitsets and register raw VAMANA #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sre-ci-robot merged 1 commit into from
Apr 29, 2026
Merged

fix(svs): allow all-clear SVS_FLAT bitsets and register raw VAMANA #1603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index/svs/svs_flat.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class SvsFlatIndexNode : public IndexNode {
return expected<DataSetPtr>::Err(Status::empty_index, "index not loaded");
}

if (!bitset.empty()) {
if (!bitset.empty() && bitset.count() > 0) {
return expected<DataSetPtr>::Err(Status::not_implemented, "SVS Flat does not support bitset filtering");
}

Expand Down
2 changes: 2 additions & 0 deletions src/index/svs/svs_vamana.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,8 @@ class SvsVamanaLeanVecIndexNode : public SvsVamanaIndexNode<DataType> {

// temporarily removed `MMAP` until it's fully honored by SVS

KNOWHERE_MOCK_REGISTER_DENSE_FLOAT_ALL_GLOBAL(SVS_VAMANA, SvsVamanaIndexNode, knowhere::feature::NONE)

KNOWHERE_MOCK_REGISTER_DENSE_FLOAT_ALL_GLOBAL(SVS_VAMANA_LVQ, SvsVamanaLvqIndexNode, knowhere::feature::NONE)

KNOWHERE_MOCK_REGISTER_DENSE_FLOAT_ALL_GLOBAL(SVS_VAMANA_LEANVEC, SvsVamanaLeanVecIndexNode, knowhere::feature::NONE)
Expand Down
Loading