Fix build errors when WITH_CARDINAL=true#1624
Conversation
|
@yhmo 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
|
/hold |
e18b26e to
c83c248
Compare
|
@yhmo e2e jenkins job failed, comment |
586e142 to
fef4147
Compare
Signed-off-by: yhmo <yihua.mo@zilliz.com>
foxspy
left a comment
There was a problem hiding this comment.
/lgtm
Going to merge first, then revert the nits later.
foxspy
left a comment
There was a problem hiding this comment.
/lgtm
Going to merge first, then revert the nits later.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: foxspy, yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind improvement |
issue: #1580
We are currently using the recipe branch of the Cardinal repository because the pull request has not yet been merged into the Cardinal repository: https://github.com/zilliztech/cardinal/pull/834. The Cardinal repository fetches Knowhere to execute the CI workflow, creating a coupling between the two repositories. To decouple them:
Expose a variable CARDINAL_VERSION_FORCE_CHECKOUT, so local/CI builds can force thirdparty/cardinalv2 to the configured branch/tag.
After this fix, both "make" command and "make WITH_CARDINAL=true" can succeed.