Skip to content

Optimize sparse query scorer dispatch#1627

Closed
lyang24 wants to merge 1 commit into
zilliztech:mainfrom
lyang24:optimize-sparse-scorer-functor
Closed

Optimize sparse query scorer dispatch#1627
lyang24 wants to merge 1 commit into
zilliztech:mainfrom
lyang24:optimize-sparse-scorer-functor

Conversation

@lyang24

@lyang24 lyang24 commented May 16, 2026

Copy link
Copy Markdown
Contributor

This change templatizes the sparse query scorer to remove std::function indirection from the hot path

@sre-ci-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lyang24
To complete the pull request process, please assign foxspy after the PR has been reviewed.
You can assign the PR to them by writing /assign @foxspy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify

mergify Bot commented May 16, 2026

Copy link
Copy Markdown

@lyang24 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Signed-off-by: lyang24 <lanqingy93@gmail.com>
@lyang24 lyang24 force-pushed the optimize-sparse-scorer-functor branch from d62c35c to f1090ba Compare May 16, 2026 04:45
@mergify

mergify Bot commented May 16, 2026

Copy link
Copy Markdown

@lyang24 e2e jenkins job failed, comment /run-e2e can trigger the job again.

@alexanderguzhva

Copy link
Copy Markdown
Collaborator

@lyang24 does it significantly affect the performance?

@eyang-2

eyang-2 commented May 18, 2026

Copy link
Copy Markdown

@lyang24 does it significantly affect the performance?

no it helps a little bit by removing runtime looks ups in hot path, its a micro optimizaiton

@alexanderguzhva

Copy link
Copy Markdown
Collaborator

waiting for #1619

@alexanderguzhva

Copy link
Copy Markdown
Collaborator

@lyang24
please rebase to master. Thanks.

@lyang24 lyang24 marked this pull request as draft May 24, 2026 17:12
@github-actions github-actions Bot added the stale label Jun 24, 2026
@github-actions github-actions Bot closed this Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants