Optimize sparse query scorer dispatch#1627
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lyang24 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@lyang24 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
d166f6c to
d62c35c
Compare
Signed-off-by: lyang24 <lanqingy93@gmail.com>
d62c35c to
f1090ba
Compare
|
@lyang24 e2e jenkins job failed, comment |
|
@lyang24 does it significantly affect the performance? |
no it helps a little bit by removing runtime looks ups in hot path, its a micro optimizaiton |
|
waiting for #1619 |
|
@lyang24 |
This change templatizes the sparse query scorer to remove std::function indirection from the hot path