Skip to content

fix: reject invalid HNSW binary metrics in static config check#1639

Merged
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
foxspy:foxspy/fix-binary-hnsw-config-ut
May 21, 2026
Merged

fix: reject invalid HNSW binary metrics in static config check#1639
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
foxspy:foxspy/fix-binary-hnsw-config-ut

Conversation

@foxspy
Copy link
Copy Markdown
Collaborator

@foxspy foxspy commented May 20, 2026

issue: #1638

Summary

  • run HNSW static config metric checks for Faiss HNSW registrations
  • use a binary metric when testing static config checks for binary data
  • add regression coverage for rejecting non-binary metrics on binary HNSW

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
@foxspy foxspy force-pushed the foxspy/fix-binary-hnsw-config-ut branch from dc77151 to d0997e0 Compare May 20, 2026 15:58
@foxspy foxspy changed the title test: use binary metric for binary config checks fix: reject invalid HNSW binary metrics in static config check May 20, 2026
@mergify mergify Bot added the ci-passed label May 20, 2026
@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, marcelo-cjl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marcelo-cjl
Copy link
Copy Markdown
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit b23a49d into zilliztech:main May 21, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants