fix: install uv inside active venv#1642
Conversation
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jamesgao-jpg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@jamesgao-jpg 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Summary
scripts/install_deps.shsouvis installed into the active virtualenv whenVIRTUAL_ENVis set.pip3 install --user uvpath for non-virtualenv installs.uvbootstrap path; this adjusts it for Jenkins jobs that already put a venv first inPATH.Test Plan
uvonPATH.uvfrom the temp venv.uvfrom the Python user bin.bash -n scripts/install_deps.shgit diff --check origin/main..origin/tmp_knowhere_python_ver_fix