Skip to content

fix: install uv inside active venv#1642

Open
jamesgao-jpg wants to merge 1 commit into
mainfrom
tmp_knowhere_python_ver_fix
Open

fix: install uv inside active venv#1642
jamesgao-jpg wants to merge 1 commit into
mainfrom
tmp_knowhere_python_ver_fix

Conversation

@jamesgao-jpg
Copy link
Copy Markdown
Collaborator

Summary

  • Fix scripts/install_deps.sh so uv is installed into the active virtualenv when VIRTUAL_ENV is set.
  • Keep the existing pip3 install --user uv path for non-virtualenv installs.
  • PR Update build scripts #1619 introduced the uv bootstrap path; this adjusts it for Jenkins jobs that already put a venv first in PATH.

Test Plan

  • Reproduced the old failure with a temporary virtualenv and no pre-existing uv on PATH.
  • Verified the virtualenv path installs and resolves uv from the temp venv.
  • Verified the non-virtualenv path still installs and resolves uv from the Python user bin.
  • bash -n scripts/install_deps.sh
  • git diff --check origin/main..origin/tmp_knowhere_python_ver_fix

Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jamesgao-jpg
To complete the pull request process, please assign marcelo-cjl after the PR has been reviewed.
You can assign the PR to them by writing /assign @marcelo-cjl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link
Copy Markdown

mergify Bot commented May 22, 2026

@jamesgao-jpg 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants