Skip to content

Remove Arguments.createArgumentsFromJSON and tests #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonalgoyal merged 1 commit into from
Apr 28, 2026
Merged

Remove Arguments.createArgumentsFromJSON and tests #1313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 1 addition & 37 deletions docs/pythonOss/markdown/_autosummary/zingg.client.Arguments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ This class helps supply match arguments to Zingg. There are 3 basic steps in any

| [`__init__`](#zingg.client.Arguments.__init__) | |
|----------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `copyArgs` | |
| [`createArgumentsFromJSON`](#zingg.client.Arguments.createArgumentsFromJSON) | Method to create an object of this class from the JSON file and phase parameter value. |
| `createArgumentsFromJSONString` | |
| [`getArgs`](#zingg.client.Arguments.getArgs) | Method to get pointer address of this class |
| `getModelId` | |
| `getZinggBaseModelDir` | |
Expand All @@ -38,22 +35,8 @@ This class helps supply match arguments to Zingg. There are 3 basic steps in any
| [`setStopWordsCutoff`](#zingg.client.Arguments.setStopWordsCutoff) | Method to set stopWordsCutoff parameter value By default, Zingg extracts 10% of the high frequency unique words from a dataset. |
| [`setTrainingSamples`](#zingg.client.Arguments.setTrainingSamples) | Method to set existing training samples to be matched. |
| [`setZinggDir`](#zingg.client.Arguments.setZinggDir) | Method to set the location for Zingg to save its internal computations and models. |
| [`writeArgumentsToJSON`](#zingg.client.Arguments.writeArgumentsToJSON) | Method to write JSON file from the object of this class |
| [`writeArgumentsToJSONString`](#zingg.client.Arguments.writeArgumentsToJSONString) | Method to create an object of this class from the JSON file and phase parameter value. |

#### \_\_init_\_()

#### *static* createArgumentsFromJSON(fileName, phase)

Method to create an object of this class from the JSON file and phase parameter value.

* **Parameters:**
* **fileName** (*String*) – The CONF parameter value of ClientOption object
* **phase** (*String*) – The PHASE parameter value of ClientOption object
* **Returns:**
The pointer containing address of the this class object
* **Return type:**
pointer([Arguments](#zingg.client.Arguments))

#### getArgs()

Expand Down Expand Up @@ -158,23 +141,4 @@ Method to set existing training samples to be matched.
Method to set the location for Zingg to save its internal computations and models. Please set it to a place where the program has to write access.

* **Parameters:**
**f** (*String*) – Zingg directory name of the models

#### writeArgumentsToJSON(fileName)

Method to write JSON file from the object of this class

* **Parameters:**
**fileName** (*String*) – The CONF parameter value of ClientOption object or file address of json file

#### writeArgumentsToJSONString()

Method to create an object of this class from the JSON file and phase parameter value.

* **Parameters:**
* **fileName** (*String*) – The CONF parameter value of ClientOption object
* **phase** (*String*) – The PHASE parameter value of ClientOption object
* **Returns:**
The pointer containing address of the this class object
* **Return type:**
pointer([Arguments](#zingg.client.Arguments))
**f** (*String*) – Zingg directory name of the models
5 changes: 0 additions & 5 deletions python/docs/_autosummary/zingg.client.Arguments.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
:nosignatures:

~Arguments.__init__
~Arguments.copyArgs
~Arguments.createArgumentsFromJSON
~Arguments.createArgumentsFromJSONString
~Arguments.getArgs
~Arguments.getModelId
~Arguments.getZinggBaseModelDir
Expand All @@ -38,8 +35,6 @@
~Arguments.setStopWordsCutoff
~Arguments.setTrainingSamples
~Arguments.setZinggDir
~Arguments.writeArgumentsToJSON
~Arguments.writeArgumentsToJSONString



Expand Down
16 changes: 0 additions & 16 deletions python/zingg/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,22 +688,6 @@ def setColumn(self, column):
"""
self.args.setColumn(column)

@staticmethod
def createArgumentsFromJSON(fileName, phase):
"""Method to create an object of this class from the JSON file and phase parameter value.

:param fileName: The CONF parameter value of ClientOption object
:type fileName: String
:param phase: The PHASE parameter value of ClientOption object
:type phase: String
:return: The pointer containing address of the this class object
:rtype: pointer(Arguments)
"""
obj = Arguments()
obj.args = getJVM().zingg.common.client.arguments.ArgumentServiceImpl().loadArguments(fileName)
return obj


class ClientOptions:
Comment thread
padam-prakash marked this conversation as resolved.
"""Class that contains Client options for Zingg object
:param phase: trainMatch, train, match, link, findAndLabel, findTrainingData, recommend etc
Expand Down
10 changes: 0 additions & 10 deletions test/testFebrl/testArgs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,16 +473,6 @@ def test_setStopWordsCutoff(self):
actual_stopWordsCutoff = java_args.getStopWordsCutoff()

self.assertEqual(actual_stopWordsCutoff, stopWordsCutoff)

def test_createArgumentsFromJSON(self):
fileName = "examples/febrl/config.json"
phase = "label"

obj = args.createArgumentsFromJSON(fileName, phase)
print("JSON file content:", obj)
print("Phase:", phase)

self.assertIsInstance(obj, Arguments)

class TestClientOptions(TestCase):

Expand Down
Loading