Skip to content

Update FebrlExample notebook to add DOCS_DIR construction #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonalgoyal merged 1 commit into from
Apr 30, 2026
+5 −4
Merged

Update FebrlExample notebook to add DOCS_DIR construction #1316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions examples/databricks/FebrlExample.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"outputs": [],
"source": [
"zinggDir = \"/models\"\n",
"modelId = \"zinggTestApr22\""
"modelId = \"zinggTestApr28\""
Comment on lines 42 to +43
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is focused on adding DOCS_DIR construction, but this hunk also changes the default modelId to a different date-stamped value. This makes the example less stable/reproducible and looks unrelated to the stated purpose; consider keeping a consistent default modelId (or deriving it from a parameter/widget) and limiting this PR to the DOCS_DIR change.

Copilot uses AI. Check for mistakes.
]
},
{
Expand Down Expand Up @@ -204,7 +204,7 @@
"outputs": [],
"source": [
"\n",
"outputTable = \"zingg_catalog.output.febrlOutput23Apr\"\n",
"outputTable = \"zingg_catalog.output.febrlOutput28Apr\"\n",
"outputPipe = UCPipe(\"resultFebrl\", outputTable)\n",
Comment on lines +207 to 208
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is described as adding DOCS_DIR construction, but it also renames the hard-coded outputTable to a new date-specific table. Unless this is required for the DOCS_DIR change, it would be better to avoid committing ephemeral table names (or make the table name configurable) to keep the notebook example repeatable.

Copilot uses AI. Check for mistakes.
"args.setOutput(outputPipe)"
]
Expand Down Expand Up @@ -630,11 +630,12 @@
},
"outputs": [],
"source": [
"\n",
"options = ClientOptions([ClientOptions.PHASE,\"generateDocs\"])\n",
"#Zingg execution for the given phase\n",
"zingg = ZinggWithSpark(args, options)\n",
"zingg.initAndExecute()\n",
"\n",
"DOCS_DIR = zinggDir + \"/\" + modelId + \"/docs/\"\n",
"dbutils.fs.ls('file:'+DOCS_DIR)\n",
"\n",
"# see the labels\n",
Expand Down Expand Up @@ -677,7 +678,7 @@
},
"pythonIndentUnit": 4
},
"notebookName": "FebrlExample",
"notebookName": "DBOSS",
"widgets": {}
Comment on lines +681 to 682
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook metadata notebookName is changed from FebrlExample to DBOSS, which appears unrelated to adding DOCS_DIR and may confuse consumers when importing/viewing the notebook. Consider keeping notebookName aligned with the file/notebook’s actual purpose/name, or omit changing it in this PR.

Copilot uses AI. Check for mistakes.
},
"language_info": {
Expand Down
Loading