From 6cef5936b47e43e144f797555f3b5d295c6545ad Mon Sep 17 00:00:00 2001
From: padam-prakash <padam@zingg.ai>
Date: Thu, 30 Apr 2026 13:28:21 +0530
Subject: [PATCH] Refactor SparkClient constructors

add overloads that accept a zFactoryClassName string.
---
 .gitignore                                    |  1 +
 .../java/zingg/spark/client/SparkClient.java  | 23 +++++++++++++++----
 2 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/.gitignore b/.gitignore
index 8e11918a6..ae9b81cb0 100644
--- a/.gitignore
+++ b/.gitignore
@@ -31,3 +31,4 @@ assembly/dependency-reduced-pom.xml
 
 # Sphinx _build
 **/_build
+/python/venv
diff --git a/spark/client/src/main/java/zingg/spark/client/SparkClient.java b/spark/client/src/main/java/zingg/spark/client/SparkClient.java
index 7868fd96f..3c4601ea2 100644
--- a/spark/client/src/main/java/zingg/spark/client/SparkClient.java
+++ b/spark/client/src/main/java/zingg/spark/client/SparkClient.java
@@ -30,22 +30,35 @@ public class SparkClient extends Client<SparkSession, Dataset<Row>, Row, Column,
 	private JavaSparkContext javaSparkContext;
 
 	public SparkClient(IZArgs args, ClientOptions options) throws ZinggClientException {
-		super(args, options, zFactoryClassName);
-		
+		this(args, options, zFactoryClassName);
 	}
 	
 
 	public SparkClient(IZArgs args, ClientOptions options, SparkSession s) throws ZinggClientException {
-		super(args, options, s, zFactoryClassName);
-		Analytics.track(Metric.IS_PYTHON, "true", args.getCollectMetrics());
+		this(args, options, s, zFactoryClassName);
 	}
 
 	
 	public SparkClient() {
-		super(zFactoryClassName);
+		this(zFactoryClassName);
+	}
+
+	public SparkClient(IZArgs args, ClientOptions options, String zFactoryClassName) throws ZinggClientException {
+		super(args, options, zFactoryClassName);
+
 	}
 
 
+	public SparkClient(IZArgs args, ClientOptions options, SparkSession s, String zFactoryClassName) throws ZinggClientException {
+		super(args, options, s, zFactoryClassName);
+		Analytics.track(Metric.IS_PYTHON, "true", args.getCollectMetrics());
+	}
+
+
+	public SparkClient(String zFactoryClassName) {
+		super(zFactoryClassName);
+	}
+
 	@Override
 	public Client<SparkSession, Dataset<Row>, Row, Column, DataType> getClient(IZArgs args, 
 		ClientOptions options) throws ZinggClientException {