Skip to content

Refactor SparkClient constructors #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonalgoyal merged 1 commit into from
Apr 30, 2026
+19 −5
Merged

Refactor SparkClient constructors #1318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@ assembly/dependency-reduced-pom.xml

# Sphinx _build
**/_build
/python/venv
23 changes: 18 additions & 5 deletions spark/client/src/main/java/zingg/spark/client/SparkClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,22 +30,35 @@ public class SparkClient extends Client<SparkSession, Dataset<Row>, Row, Column,
private JavaSparkContext javaSparkContext;

public SparkClient(IZArgs args, ClientOptions options) throws ZinggClientException {
super(args, options, zFactoryClassName);

this(args, options, zFactoryClassName);
}


public SparkClient(IZArgs args, ClientOptions options, SparkSession s) throws ZinggClientException {
super(args, options, s, zFactoryClassName);
Analytics.track(Metric.IS_PYTHON, "true", args.getCollectMetrics());
this(args, options, s, zFactoryClassName);
}


public SparkClient() {
super(zFactoryClassName);
this(zFactoryClassName);
}

public SparkClient(IZArgs args, ClientOptions options, String zFactoryClassName) throws ZinggClientException {
super(args, options, zFactoryClassName);

Comment thread
padam-prakash marked this conversation as resolved.
}


public SparkClient(IZArgs args, ClientOptions options, SparkSession s, String zFactoryClassName) throws ZinggClientException {
super(args, options, s, zFactoryClassName);
Analytics.track(Metric.IS_PYTHON, "true", args.getCollectMetrics());
}
Comment thread
padam-prakash marked this conversation as resolved.


public SparkClient(String zFactoryClassName) {
super(zFactoryClassName);
}

Comment thread
padam-prakash marked this conversation as resolved.
@Override
public Client<SparkSession, Dataset<Row>, Row, Column, DataType> getClient(IZArgs args,
ClientOptions options) throws ZinggClientException {
Expand Down
Loading