Fix perf runner json#7
Open
Chandanydv1234 wants to merge 29 commits into
Open
Conversation
sonalgoyal
reviewed
Jun 25, 2026
sonalgoyal
left a comment
Member
There was a problem hiding this comment.
can you make this into a csv file? I dont want json.
sonalgoyal
requested changes
Jun 27, 2026
|
|
||
| - name: Plot results | ||
| run: | | ||
| python3 plot_result.py |
Member
There was a problem hiding this comment.
can u send me the pr against oss action and not here. this is not the place we run our actions
| @@ -0,0 +1,21 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
please clear out dummy configs
dd15412 to
6261ae6
Compare
6261ae6 to
c06dbbe
Compare
LOGANBLUE1
approved these changes
Jun 29, 2026
sonalgoyal
requested changes
Jun 29, 2026
| WINDOW_THRESHOLD = 10 #set 10 minutes window threshold | ||
|
|
||
| def detect_pc_specs(): | ||
| specs = {} |
Member
There was a problem hiding this comment.
please move all stuff to the script, leave only running part and passing params in action in respective code repors of oss and ent
c06dbbe to
afcf0f0
Compare
afcf0f0 to
700679c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously after the initial run the report was being over written every single execution. This meant loosing the older record data.
This PR modifies the script to store all the performance records and maintain a complete history of every single execution.
Changes made:-
3.Retrieves the last run (data[-1]) in load_results for the threshold comparison.
4.Enables backward compatibility for the old dictionary formatted reports to automatically wrap them inside a list.
#2 Changes Made:-
#3 Changes Made:-