feat: Restore original attributes on destroy#39
Merged
Conversation
- Add shared AttributeSnapshot utility (remember/restore/clear) in utils.ts, exported from the ESM build alongside deepMerge - destroy() now restores role, hidden, aria-hidden, aria-controls and aria-expanded/aria-selected to their original state instead of unconditionally removing them - Fix: destroy no longer removes author-defined role/aria-controls/aria-expanded that collapsable did not add - Generated ids and rewritten href (#->#id) are intentionally kept
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Při
destroy()se DOM atributy nově vracejí do původního stavu jednotným vzorem místo bezpodmínečného odebírání.AttributeSnapshot(remember/restore/clear) vutils.ts, exportovaná z ESM buildu vedledeepMerge.destroy()revertujerole,hidden,aria-hidden,aria-controlsaaria-expanded/aria-selectedna původní hodnotu (vrátí / odebere / no-op podle snapshotu pořízeného vprepareDOM).destroy()dřív bezpodmínečně mazal i autorem ručně zadanérole/aria-controls/aria-expanded, které collapsable nepřidal — nově se zachovají.hidden/aria-hiddenopravuje reálný bug s viditelností boxů po zrušení collapsable (focus management v menu).id(bez vedlejšího efektu) a přepsanýhref#→#id(sémanticky správně ponechat).